[sync] T5593 fix(ai): transcribe voice input after recording#3489
[sync] T5593 fix(ai): transcribe voice input after recording#3489tea-artist wants to merge 1 commit into
Conversation
Synced from teableio/teable-ee@3401636 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
1 similar comment
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c8cf77627
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (this.cls.get('useV2')) { | ||
| return this.pasteByIdWithV2(tableId, pasteRo); |
There was a problem hiding this comment.
Add shared-view guards to by-id mutations
In share-view requests (shareViewId in CLS), this new by-id path (and the analogous clear/delete by-id and by-id-stream paths added below) mutates directly from client-supplied IDs without calling shareViewScopeService.assertPaste/assertSelectionMutation, unlike the adjacent range endpoints. An editable share viewer can therefore craft recordIds/fieldIds outside the shared view or hidden columns and paste/clear/delete them; add the same share-scope checks before dispatching these by-id mutations.
Useful? React with 👍 / 👎.
| await streamSSE<IDeleteSelectionStreamEvent>( | ||
| url, | ||
| { | ||
| method: 'POST', |
There was a problem hiding this comment.
Use PATCH for the exported delete stream helper
deleteByIdSelectionStream is exported from selection/index.ts, but this helper sends POST while the Nest controller registers /delete-by-id-stream with @Patch (checked SelectionController.deleteByIdStream). Consumers using this helper will hit no matching streamed-delete endpoint instead of receiving SSE progress; keep the helper/route metadata on PATCH like deleteSelectionByIdStream.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
🔄 Automated sync from EE repository.
252 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@3401636
This PR was automatically created by the sync workflow.